Fix crash in copyVolumeDataPodFunc when location type is not GCS (#2072)

* FIx crash in copyVolumeDataPodFunc when location type is not GCS

* Address review comments

* Fix NopRemover receiver

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

pkg/function/copy_volume_data.go

@@ -99,6 +99,7 @@ func copyVolumeDataPodFunc(cli kubernetes.Interface, tp param.TemplateParams, na
 			return nil, errors.Wrapf(err, "Failed to write credentials to Pod %s", pc.PodName())
 		}
 
+		// Parent context could already be dead, so removing file within new context
 		defer remover.Remove(context.Background()) //nolint:errcheck
 
 		pod := pc.Pod()

pkg/function/utils.go

@@ -99,6 +99,19 @@ func ValidateProfile(profile *param.Profile) error {
 	return nil
 }
 
+type nopRemover struct {
+}
+
+var _ kube.PodFileRemover = nopRemover{}
+
+func (nr nopRemover) Remove(ctx context.Context) error {
+	return nil
+}
+
+func (nr nopRemover) Path() string {
+	return ""
+}
+
 // WriteCredsToPod creates a file with Google credentials if the given profile points to a GCS location
 func WriteCredsToPod(ctx context.Context, writer kube.PodFileWriter, profile *param.Profile) (kube.PodFileRemover, error) {
 	if profile.Location.Type == crv1alpha1.LocationTypeGCS {
@@ -109,7 +122,7 @@ func WriteCredsToPod(ctx context.Context, writer kube.PodFileWriter, profile *pa
 
 		return remover, nil
 	}
-	return nil, nil
+	return nopRemover{}, nil
 }
 
 // GetPodWriter creates a file with Google credentials if the given profile points to a GCS location