TestBucketGetRegions fails intermittently (#1125)

* TestBucketGetRegions is flaky

* addressed review comments

* addressed review comments

* [nit] Adding space

Co-authored-by: Pavan Navarathna <pavan@kasten.io>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

pkg/objectstore/objectstore_test.go

@@ -438,15 +438,28 @@ func (s *ObjectStoreProviderSuite) TestBucketGetRegions(c *C) {
 		c.Skip("Test only applicable to S3")
 	}
 	ctx := context.Background()
-	buckets, err := s.provider.ListBuckets(ctx)
+	origBucket, err := s.provider.GetBucket(ctx, testBucketName)
 	c.Assert(err, IsNil)
+	c.Assert(origBucket, NotNil)
+
+	// Creating an object in existing bucket to check it later when we call GetOrCreateBucket,
+	// to see if existing bucket was returned
+	orgBucketObjectName := s.suiteDirPrefix + "GetRegions"
+	err = origBucket.PutBytes(ctx, orgBucketObjectName, []byte("content-getRegions"), nil)
+	c.Assert(err, IsNil)
+	defer func() {
+		err = origBucket.Delete(ctx, orgBucketObjectName)
+		c.Assert(err, IsNil)
+	}()
+
 	b, err := GetOrCreateBucket(ctx, s.provider, testBucketName)
 	c.Assert(err, IsNil)
 	c.Assert(b, NotNil)
-	// Make sure no new bucket was created
-	newBuckets, err := s.provider.ListBuckets(ctx)
+
+	// Checking if same bucket was returned by checking if object
+	// that was created previously exists in newly retrieved bucket
+	_, _, err = b.Get(ctx, orgBucketObjectName)
 	c.Assert(err, IsNil)
-	c.Assert(newBuckets, HasLen, len(buckets))
 
 	l, err := b.ListObjects(ctx)
 	c.Assert(err, IsNil)