Skip to content

Commit

Permalink
Feature flagging for exporting of Kanister prometheus metrics (#2235)
Browse files Browse the repository at this point in the history
* Added new metrics.enabled flag to helm chart

* Added new environment variable to capture the metrics.enabled flag from helm chart values.yaml

* Addressed Pavan's review comments
  • Loading branch information
mellon-collie authored Aug 4, 2023
1 parent 9001dda commit 93e668f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
2 changes: 2 additions & 0 deletions helm/kanister-operator/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ spec:
value: {{ .Values.controller.logLevel }}
- name: DATA_STORE_PARALLEL_UPLOAD
value: {{ .Values.controller.parallelism | quote }}
- name: KANISTER_METRICS_ENABLED
value: {{ .Values.controller.metrics.enabled | quote }}
{{- if .Values.resources }}
resources:
{{ toYaml .Values.resources | indent 12 }}
Expand Down
5 changes: 5 additions & 0 deletions helm/kanister-operator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ controller:
# true : CRDs would be created by kanister controller
updateCRDs: true
parallelism: 8
metrics:
# metrics.enabled specified if the kanister-prometheus framework has been enabled
# false : kanister-prometheus framework has been disabled
# true: kanister-prometheus framework has been enabled
enabled: false
bpValidatingWebhook:
enabled: true
tls:
Expand Down

0 comments on commit 93e668f

Please sign in to comment.