Skip to content

Commit

Permalink
Don't upload full dir from gomod step, make some steps parallel.
Browse files Browse the repository at this point in the history
Uploading/downloading the artifact takes longer than setting up deps
in the test and build steps most of the time.
  • Loading branch information
hairyhum committed Dec 14, 2023
1 parent c9b2f86 commit ab17110
Showing 1 changed file with 23 additions and 30 deletions.
53 changes: 23 additions & 30 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
name: Build and test
on:
push:
branches:
Expand All @@ -8,37 +9,37 @@ on:
jobs:
gomod:
runs-on: ubuntu-20.04
outputs:
gomod: ${{ steps.output.outputs.gomod }}
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- run: make go-mod-tidy
- run: make go-mod-download
- run: tar -cvf ./src.tar.gz ./ # preserve file permissions
- uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
with:
name: src
path: ./src.tar.gz
- id: output
run: |
{
echo 'gomod<<FILE'
cat go.mod
echo
echo FILE
} >> "$GITHUB_OUTPUT"
lint:
runs-on: ubuntu-20.04
needs: gomod
steps:
- uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3.0.2
with:
name: src
- run: tar -xvf ./src.tar.gz
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- run: echo "${{needs.gomod.outputs.gomod}}" > go.mod
- run: make golint
test:
runs-on: ubuntu-20.04
needs: [gomod, lint]
needs: gomod
strategy:
fail-fast: false
matrix:
testSuite: [test, integration-test, helm-test]
steps:
- uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3.0.2
with:
name: src
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- run: echo "${{needs.gomod.outputs.gomod}}" > go.mod
- uses: helm/kind-action@v1.8.0
- run: tar -xvf ./src.tar.gz
- run: |
make install-csi-hostpath-driver
make install-minio
Expand All @@ -53,42 +54,34 @@ jobs:
- run: make ${{ matrix.testSuite }}
build:
runs-on: ubuntu-20.04
needs: [gomod, lint, test]
needs: gomod
strategy:
matrix:
bin: [controller, kanctl, kando]
steps:
- uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3.0.2
with:
name: src
- run: tar -xvf ./src.tar.gz
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- run: echo "${{needs.gomod.outputs.gomod}}" > go.mod
- run: make build BIN=${{ matrix.bin }} GOBORING=true
docs:
runs-on: ubuntu-20.04
needs: gomod
steps:
- uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3.0.2
with:
name: src
- run: tar -xvf ./src.tar.gz
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- run: make docs
release:
runs-on: ubuntu-20.04
needs: [test, build]
needs: [lint, test, build, docs]
if: github.ref_name == 'master' || startsWith(github.ref, 'refs/tags')
permissions:
packages: write
steps:
- uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3.0.2
with:
name: src
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- run: make go-mod-tidy
- uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d # v3.0.0
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- run: sudo rm -rf /usr/share/dotnet
- run: sudo rm -rf "$AGENT_TOOLSDIRECTORY"
- run: tar -xvf ./src.tar.gz
- run: make release-snapshot
- run: ./build/push_images.sh

0 comments on commit ab17110

Please sign in to comment.