Addressed review comments

.goreleaser.yml

@@ -82,11 +82,6 @@ dockers:
   dockerfile: 'docker/kanister-kubectl/Dockerfile'
   build_flag_templates:
   - "--build-arg=TOOLS_IMAGE=ghcr.io/kanisterio/kanister-tools:{{ .Tag }}"
-- ids:
-  - kando
-  image_templates:
-  - 'ghcr.io/kanisterio/redis-tools:{{ .Tag }}'
-  dockerfile: 'docker/redis-tools/Dockerfile'
 - ids:
   - kando
   image_templates:

build/push_images.sh

@@ -18,7 +18,7 @@ set -o errexit
 set -o nounset
 
 IMAGE_REGISTRY="ghcr.io/kanisterio"
-IMAGES=("mysql-sidecar" "redis-tools" "kafka-adobe-s3-sink-connector" "postgres-kanister-tools" "postgresql" "cassandra" "kanister-kubectl-1.18" "mongo-sidecar" "mongodb" "es-sidecar" "controller" "kanister-tools" "couchbase-tools" "kafka-adobe-s3-source-connector" "foundationdb" "mssql-tools")
+IMAGES=("mysql-sidecar" "kafka-adobe-s3-sink-connector" "postgres-kanister-tools" "postgresql" "cassandra" "kanister-kubectl-1.18" "mongo-sidecar" "mongodb" "es-sidecar" "controller" "kanister-tools" "couchbase-tools" "kafka-adobe-s3-source-connector" "foundationdb" "mssql-tools")
 
 TAG=${1:-"v9.99.9-dev"}
 

docker/redis-tools/Dockerfile

@@ -1,10 +1,9 @@
 FROM redis:7.0.7
 
-ADD kando /usr/local/bin/
-
 RUN apt update
 RUN apt install -y npm bash curl redis-tools
 RUN curl -fsSL https://deb.nodesource.com/setup_current.x | bash - && apt install -y nodejs
 RUN npm install redis-dump -g
 
+RUN curl https://raw.githubusercontent.com/kanisterio/kanister/master/scripts/get.sh | bash
 CMD [ "/usr/bin/tail", "-f", "/dev/null" ]

examples/redis/README.md

@@ -13,6 +13,15 @@ We will be using [Redis](https://github.com/bitnami/charts/tree/main/bitnami/red
 - PV provisioner support in the underlying infrastructure
 - Kanister controller version 0.85.0 installed in your cluster, let's assume in Namespace `kanister`
 - Kanctl CLI installed (https://docs.kanister.io/tooling.html#install-the-tools)
+- Redis docker image. To build and push the docker image to registry, please execute [these](#build-docker-image) steps.
+
+### Build docker image
+- Execute below commands to build and push `redis-tools` docker image to a registry.
+```bash
+$ cd ~/kanister/docker/redis-tools
+$ docker build -t <registry>/<account_name>/redis-tools:<tag_name> .
+$ docker push <registry>/<account_name>/redis-tools:<tag_name>
+```
 
 ## Installing the Chart
 
@@ -68,6 +77,10 @@ can be shared between Kanister-enabled application instances.
 
 Create Blueprint in the same namespace as the Kanister controller
 
+**NOTE:**
+
+Please replace `<registry>`, `<account_name>` and `<tag_name>` for the image value in `./redis-blueprint.yaml` before running following command.
+
 ```bash
 $ kubectl create -f ./redis-blueprint.yaml -n kanister
 ```

examples/redis/redis-blueprint.yaml

@@ -17,7 +17,7 @@ actions:
           name: '{{ index .Object.metadata.labels "app.kubernetes.io/instance" }}'
           namespace: '{{ .StatefulSet.Namespace }}'
       args:
-        image: ghcr.io/kanisterio/redis-tools:0.85.0
+        image: <registry>/<account_name>/redis-tools:<tag_name>
         namespace: "{{ .StatefulSet.Namespace }}"
         command:
         - bash
@@ -43,7 +43,7 @@ actions:
           name: '{{ index .Object.metadata.labels "app.kubernetes.io/instance" }}'
           namespace: '{{ .StatefulSet.Namespace }}'
       args:
-        image: ghcr.io/kanisterio/redis-tools:0.85.0
+        image: <registry>/<account_name>/redis-tools:<tag_name>
         namespace: "{{ .StatefulSet.Namespace }}"
         command:
         - bash
@@ -63,7 +63,7 @@ actions:
     - func: KubeTask
       name: deleteFromBlobStore
       args:
-        image: ghcr.io/kanisterio/redis-tools:0.85.0
+        image: <registry>/<account_name>/redis-tools:<tag_name>
         namespace: "{{ .Namespace.Name }}"
         command:
         - bash