Apply suggestions from code review

Co-authored-by: Prasad Ghangal <prasad.ghangal@gmail.com>
kanisterio · Jun 22, 2021 · ec74f30 · ec74f30
1 parent 9370325
commit ec74f30
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/pkg/app/app.go b/pkg/app/app.go
@@ -39,7 +39,7 @@ type App interface {
 	Object() crv1alpha1.ObjectReference
 	// Uninstall deletes an app and all it's components from a Namespace.
 	Uninstall(context.Context) error
-	// Get ClusterLevelResources for the app
+	// GetClusterScopedResources returns the list of cluster scoped k8s resources created during app Install
 	GetClusterScopedResources(context.Context) []crv1alpha1.ObjectReference
 }
 

diff --git a/pkg/app/kafka.go b/pkg/app/kafka.go
@@ -165,6 +165,7 @@ func (kc *KafkaCluster) Install(ctx context.Context, namespace string) error {
 
 func (kc *KafkaCluster) GetClusterScopedResources(ctx context.Context) []crv1alpha1.ObjectReference {
 	return []crv1alpha1.ObjectReference{
+	// ClusterRoles
 		{
 			APIVersion: "v1",
 			Group:      "rbac.authorization.k8s.io",
@@ -201,6 +202,8 @@ func (kc *KafkaCluster) GetClusterScopedResources(ctx context.Context) []crv1alp
 			Name:       "strimzi-kafka-broker",
 			Resource:   "clusterroles",
 		},
+
+		// ClusterRoleBindings
 		{
 			APIVersion: "v1",
 			Group:      "rbac.authorization.k8s.io",
@@ -219,6 +222,8 @@ func (kc *KafkaCluster) GetClusterScopedResources(ctx context.Context) []crv1alp
 			Name:       "strimzi-cluster-operator-kafka-client-delegation",
 			Resource:   "clusterrolebindings",
 		},
+
+		// CRDs
 		{
 			APIVersion: "v1",
 			Group:      "apiextensions.k8s.io",