addressing nits

pkg/kopia/cli/args/ephemeral_args.go

@@ -41,10 +41,11 @@ func (a *Args) Set(key, value string) {
 	a.args[key] = value
 }
 
-func (a *Args) AppendToCmd(cmd *logsafe.Cmd) {
+func (a *Args) AppendToCmd(cmd logsafe.Cmd) logsafe.Cmd {
 	for k, v := range a.args {
-		*cmd = cmd.AppendLoggableKV(k, v)
+		cmd = cmd.AppendLoggableKV(k, v)
 	}
+	return cmd
 }
 
 func (a *Args) CommandAppliers() []command.Applier {

pkg/kopia/command/repository.go

@@ -99,7 +99,7 @@ func RepositoryCreateCommand(cmdArgs RepositoryCommandArgs) ([]string, error) {
 		command = command.AppendLoggableKV(retentionPeriodFlag, cmdArgs.RetentionPeriod.String())
 	}
 
-	args.RepositoryCreate.AppendToCmd(&command)
+	command = args.RepositoryCreate.AppendToCmd(command)
 
 	bsArgs, err := storage.KopiaStorageArgs(&storage.StorageCommandParams{
 		Location:       cmdArgs.Location,
@@ -152,7 +152,7 @@ func RepositoryConnectServerCommand(cmdArgs RepositoryServerCommandArgs) []strin
 	}
 	command = command.AppendLoggableKV(urlFlag, cmdArgs.ServerURL)
 
-	args.RepositoryConnectServer.AppendToCmd(&command)
+	command = args.RepositoryConnectServer.AppendToCmd(command)
 
 	command = command.AppendRedactedKV(serverCertFingerprint, cmdArgs.Fingerprint)
 

pkg/kopia/command/repository_test.go

@@ -189,9 +189,6 @@ func (s *RepositoryUtilsSuite) TestRepositoryCreateUtil(c *check.C) {
 			args.RepositoryCreate.Set("--testflag", "testvalue")
 			defer func() { args.RepositoryCreate = flags }()
 		}
-		// else {
-		// 	defer func() { args.RepositoryCreate = flags }()
-		// }
 		cmd, err := RepositoryCreateCommand(tc.cmdArg)
 		c.Assert(err, tc.Checker)
 		if tc.Checker == check.IsNil {

pkg/kopia/command/server.go

@@ -130,7 +130,7 @@ func ServerSetUser(cmdArgs ServerSetUserCommandArgs) []string {
 	command = command.AppendLoggable(serverSubCommand, userSubCommand, setSubCommand, cmdArgs.NewUsername)
 	command = command.AppendRedactedKV(userPasswordFlag, cmdArgs.UserPassword)
 
-	args.UserAddSet.AppendToCmd(&command)
+	command = args.UserAddSet.AppendToCmd(command)
 
 	return stringSliceCommand(command)
 }
@@ -147,7 +147,7 @@ func ServerAddUser(cmdArgs ServerAddUserCommandArgs) []string {
 	command = command.AppendLoggable(serverSubCommand, userSubCommand, addSubCommand, cmdArgs.NewUsername)
 	command = command.AppendRedactedKV(userPasswordFlag, cmdArgs.UserPassword)
 
-	args.UserAddSet.AppendToCmd(&command)
+	command = args.UserAddSet.AppendToCmd(command)
 
 	return stringSliceCommand(command)
 }

pkg/kopia/repository/client.go

@@ -34,7 +34,7 @@ import (
 const (
 	defaultConnectMaxListCacheDuration time.Duration = time.Second * 600
 	kopiaGetRepoParametersError                      = "unable to get repository parameters"
-	pbkdf2Algorithm                                  = "pbkdf2-sha256-600000"
+	Pbkdf2Algorithm                                  = "pbkdf2-sha256-600000"
 )
 
 // ConnectToAPIServer connects to the Kopia API server running at the given address
@@ -57,7 +57,7 @@ func ConnectToAPIServer(
 	serverInfo := &repo.APIServerInfo{
 		BaseURL:                             serverAddress,
 		TrustedServerCertificateFingerprint: fingerprint,
-		LocalCacheKeyDerivationAlgorithm:    pbkdf2Algorithm,
+		LocalCacheKeyDerivationAlgorithm:    Pbkdf2Algorithm,
 	}
 
 	opts := &repo.ConnectOptions{

pkg/kopia/repository/client_test.go

@@ -1,10 +1,11 @@
-package repository
+package repository_test
 
 import (
 	"testing"
 
 	"gopkg.in/check.v1"
 
+	"github.com/kanisterio/kanister/pkg/kopia/repository"
 	"github.com/kopia/kopia/repo"
 )
 
@@ -17,7 +18,7 @@ var _ = check.Suite(&RepositoryClientSuite{})
 func (s *RepositoryClientSuite) TestKopiaAllowedAlgorithms(c *check.C) {
 	pbkdf2Supported := false
 	for _, algorithm := range repo.SupportedLocalCacheKeyDerivationAlgorithms() {
-		if algorithm == pbkdf2Algorithm {
+		if algorithm == repository.Pbkdf2Algorithm {
 			pbkdf2Supported = true
 		}
 	}