Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace github.com/satori/go.uuid (CVE-2021-3538) #1368

Closed
muffl0n opened this issue Apr 7, 2022 · 1 comment · Fixed by #1441
Closed

Replace github.com/satori/go.uuid (CVE-2021-3538) #1368

muffl0n opened this issue Apr 7, 2022 · 1 comment · Fixed by #1441
Assignees
@chaitanya-baraskar
Labels
dependencies Pull requests that update a dependency file security Security related issues

Comments

@muffl0n
Copy link
Contributor

muffl0n commented Apr 7, 2022

Last release of https://github.com/satori/go.uuid is 1.2.0 from 2018 and contains CVE-2021-3538.

I'm not sure what an appropriate replacement would be. Maybe https://pkg.go.dev/gitee.com/gofrs/uuid like mentioned in satori/go.uuid#118?
@ihcsim ihcsim added the triage label Apr 10, 2022
@pavannd1 pavannd1 added dependencies Pull requests that update a dependency file security Security related issues and removed enhancement labels Apr 11, 2022
@ihcsim
Copy link
Contributor

ihcsim commented Apr 11, 2022 •
edited
Loading

@muffl0n Thanks for raising this issue. Yes, we need to fix this.

Affected code:

✗ grep -rniI "github.com\/satori\/go.uuid" pkg                                                                                                 
pkg/testutil/mockblockstorage/mockblockstorage.go:23:   uuid "github.com/satori/go.uuid"
pkg/blockstorage/gcepd/gcepd.go:29:     uuid "github.com/satori/go.uuid"
pkg/blockstorage/awsefs/awsefs.go:28:   uuid "github.com/satori/go.uuid"
pkg/blockstorage/azure/azuredisk.go:16: uuid "github.com/satori/go.uuid"
pkg/blockstorage/vmware/vmware.go:14:   uuid "github.com/satori/go.uuid"

@ihcsim ihcsim removed the triage label Apr 13, 2022
@chaitanya-baraskar chaitanya-baraskar mentioned this issue May 17, 2022
Merged
10 tasks
@mergify mergify bot closed this as completed in #1441 May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chaitanya-baraskar chaitanya-baraskar

Labels
dependencies Pull requests that update a dependency file security Security related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CVE 2021 3538 fix kanisterio/kanister
4 participants
@muffl0n @ihcsim @pavannd1 @chaitanya-baraskar