CVE 2021 3538 fix #1441
Merged
CVE 2021 3538 fix #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
chaitanya-baraskar
force-pushed
the
CVE-2021-3538
branch
from
c6d4a55
to
3b3ce9e
Compare
julio-lopez
reviewed
May 17, 2022
pavannd1
reviewed
May 17, 2022
julio-lopez
reviewed
May 18, 2022
go.mod
Outdated
| @@ -103,7 +102,7 @@ require ( | |||
| github.com/go-openapi/jsonreference v0.19.5 // indirect | |||
| github.com/go-openapi/swag v0.19.14 // indirect | |||
| github.com/go-stack/stack v1.8.0 // indirect | |||
| github.com/gofrs/uuid v4.0.0+incompatible // indirect | |||
| github.com/gofrs/uuid v4.2.0+incompatible | |||
There was a problem hiding this comment.
This should go in the direct dependencies.
Has go mod tidy -compat=1.17 been run? Does it change the file?
There was a problem hiding this comment.
Let me check. I only ran go mod tidy before raising PR.
|
@chaitanya-baraskar You may have to rebase and run |
…VE-2021-3538 � Conflicts: � go.sum
chaitanya-baraskar
force-pushed
the
CVE-2021-3538
branch
from
447ab94
to
b2db536
Compare
|
Reorganize the code a bit to reduce complexity - maybe split logical modules into helper functions |
chaitanya-baraskar
force-pushed
the
CVE-2021-3538
branch
from
b2db536
to
8bb7e06
Compare
julio-lopez
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Fix for CVE-2021-3538. Using
github.com/gofrs/uuidinstead ofgit.luolix.top/satori/go.uuidfor uuid.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Executed
make all-buildto build code.