-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CVE 2021 3538 fix #1441
CVE 2021 3538 fix #1441
Conversation
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
c6d4a55
to
3b3ce9e
Compare
go.mod
Outdated
@@ -103,7 +102,7 @@ require ( | |||
github.com/go-openapi/jsonreference v0.19.5 // indirect | |||
github.com/go-openapi/swag v0.19.14 // indirect | |||
github.com/go-stack/stack v1.8.0 // indirect | |||
github.com/gofrs/uuid v4.0.0+incompatible // indirect | |||
github.com/gofrs/uuid v4.2.0+incompatible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go in the direct dependencies.
Has go mod tidy -compat=1.17
been run? Does it change the file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check. I only ran go mod tidy
before raising PR.
@chaitanya-baraskar You may have to rebase and run |
…VE-2021-3538 � Conflicts: � go.sum
447ab94
to
b2db536
Compare
Reorganize the code a bit to reduce complexity - maybe split logical modules into helper functions
|
b2db536
to
8bb7e06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge and iterate if needed
Change Overview
Fix for CVE-2021-3538. Using
github.com/gofrs/uuid
instead ofgit.luolix.top/satori/go.uuid
for uuid.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Executed
make all-build
to build code.