Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Don't dump the entire pod spec in the controller's logs #1464

Closed
viveksinghggits opened this issue Jun 8, 2022 · 2 comments
Closed
Assignees
Labels
bug cleanup Code cleanup and refactor help wanted

Comments

@viveksinghggits
Copy link
Contributor

Describe the bug
In the cases where we are using KubeTask kanister function (I think should be reproducible with any function that spins up new pod), if the command that we are running there fails we dump the entire pod spec in the controller's logs which is not useful in most of cases.
Instead of dumping the entire pod spec we should just log the information (specific fields from pod.Spec) that we might need from the pod.

To Reproduce
Steps to reproduce the behavior:

  1. Use a blueprint that has KubeTask function in it, MySQL for example. And make sure that phase fails (we can add a command that doesn't exist and the phase will fail)
  2. Run backup action, you can follow this readme to do that.
  3. See the controller's logs and you will see the entire pod spec dumped in the logs

Expected behavior
We should just log the specific fields from pod.Spec that we might need to debug the problem.

Screenshots

image

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

Thanks for opening this issue 👍. The team will review it shortly.

If this is a bug report, make sure to include clear instructions how on to reproduce the problem with minimal reproducible examples, where possible. If this is a security report, please review our security policy as outlined in SECURITY.md.

If you haven't already, please take a moment to review our project's Code of Conduct document.

@akankshakumari393
Copy link
Contributor

akankshakumari393 commented Jun 22, 2022

@viveksinghggits I agree that adding entire pod spec in the controller's logs is not useful in most of cases. But it might be useful in the cases where we would want to debug the state of the Pod at the point it failed. Also, I think there is no useful information in the dump string which we would want to filter out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cleanup Code cleanup and refactor help wanted
Projects
None yet
Development

No branches or pull requests

4 participants