Dump Pod Status in logs instead of complete PodSpec #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
akankshakumari393
changed the title
pavannd1
reviewed
Jun 24, 2022
pkg/kube/pod.go
Outdated
| @@ -299,7 +299,7 @@ func WaitForPodCompletion(ctx context.Context, cli kubernetes.Interface, namespa | |||
| } | |||
| switch p.Status.Phase { | |||
| case v1.PodFailed: | |||
| return false, errors.Errorf("Pod %s failed. Pod details (%s)", name, log.SafeDumpPodObject(p)) | |||
| return false, errors.Errorf("Pod %s failed. Pod Status details (%s)", name, log.SafeDumpPodStatusObject(p)) | |||
There was a problem hiding this comment.
We can just use p.Status.String() directly. Changes to helper and the tests will not be necessary
There was a problem hiding this comment.
Agreed - then we can also remove log.SafeDumpPodObject().
pavannd1
approved these changes
Jun 28, 2022
Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
As of now we used to dump all Pod Spec in logs in case of error or pod failure. This PR is to dump only the Pod Status and not all Spec.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Controller logs that shows only PodStatus for a Failed Mysql blueprint actionSet https://gist.github.com/akankshakumari393/3402379b3e6440f5ecd934af5204b649