Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variable registration mechanism for ephemeral pods #2856

Closed
kidgilson opened this issue May 2, 2024 · 1 comment · Fixed by #2874
Closed

Add environment variable registration mechanism for ephemeral pods #2856

kidgilson opened this issue May 2, 2024 · 1 comment · Fixed by #2874
Assignees
Projects

Comments

@kidgilson
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Ephemeral pods launched by Kanister need to have environment variables injected based on the outer OS environment variables (parent pod that launched these ephemeral pods) or based on static environment variables that need to be added.

The possible set of conditional environment variables needs to be registered and if found in the outer OS then should be injected. The static environment variables, when registered, should always be added to the container environment variables.

Describe the solution you'd like
Add an ephemeral package which has a registration scheme for environment variables which can be used outside Kanister to register which environment variables you'd like injected.

Additional context
This helps to get the correct FIPS required environment variables into the ephemeral pods to ensure the crypto backend is started in FIPS mode.

@kidgilson kidgilson self-assigned this May 2, 2024
@github-actions github-actions bot added the triage label May 2, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

Thanks for opening this issue 👍. The team will review it shortly.

If this is a bug report, make sure to include clear instructions how on to reproduce the problem with minimal reproducible examples, where possible. If this is a security report, please review our security policy as outlined in SECURITY.md.

If you haven't already, please take a moment to review our project's Code of Conduct document.

@infraq infraq added this to To Be Triaged in Kanister May 2, 2024
@mergify mergify bot closed this as completed in #2874 May 10, 2024
Kanister automation moved this from To Be Triaged to Done May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment