Add new ephemeral package for registering and applying PodOptions changes #2874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidgilson
changed the title
kidgilson
force-pushed
the
ephemeral-package-podoptions
branch
from
f9c1f5a
to
25fd167
Compare
kidgilson
force-pushed
the
ephemeral-package-podoptions
branch
from
25fd167
to
737f0b7
Compare
10 tasks
pavannd1
reviewed
May 10, 2024
pavannd1
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR introduces the ephemeral package meant to handle registering and applying ephemeral pod specific fields.
The first use-case was to introduce FIPS related environment variables that need to be set on all ephemeral pods to ensure the crypto backend (OpenSSL in this case) is started with the FIPS provider enabled and fails otherwise.
The registration mechanism is made to be generic by using an
Applierinterface which is used to register different ways of applying changes to a*kube.PodOptionsor a*corev1.Container.For now convenience functions related to registering environment variable Applier's are added. The conditional environment variable helper is the OSEnvVar function which looks to see if the environment variable is set on the OS and applies it to the ephemeral pod if so. This usage is the main need for setting the FIPS environment variables since they're already present on the parent pod launching the ephemeral pods.
All places that used the
kube.PodOptionsandcorev1.Containertypes have the ephemeral.Options.Apply() function added which adds all registered Appliers (only environment variables at this point) to the pod.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan