-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] ActionSet artifacts fail to populate in multi-action actionsets #2882
Comments
Thanks for opening this issue 👍. The team will review it shortly. If this is a bug report, make sure to include clear instructions how on to reproduce the problem with minimal reproducible examples, where possible. If this is a security report, please review our security policy as outlined in SECURITY.md. If you haven't already, please take a moment to review our project's Code of Conduct document. |
hairyhum
added a commit
that referenced
this issue
May 10, 2024
If there are multiple actions running in parallel, they will populate artifacts while another action is still running. This causes a conflict in update of actionset state. Actionset state should be updated only when all actions complete by onUpdateActionSet Fixes #2882
10 tasks
hairyhum
added a commit
that referenced
this issue
May 13, 2024
If there are multiple actions running in parallel, they will populate artifacts while another action is still running. This causes a conflict in update of actionset state. Actionset state should be updated by separate function maybeSetActionSetStateComplete Fixes #2882
hairyhum
added a commit
that referenced
this issue
May 13, 2024
If there are multiple actions running in parallel, they will populate artifacts while another action is still running. This causes a conflict in update of actionset state. Actionset state should be updated by separate function maybeSetActionSetStateComplete Fixes #2882
hairyhum
added a commit
that referenced
this issue
May 13, 2024
If there are multiple actions running in parallel, they will populate artifacts while another action is still running. This causes a conflict in update of actionset state. Actionset state should be updated by separate function maybeSetActionSetStateComplete Fixes #2882
mergify bot
added a commit
that referenced
this issue
May 22, 2024
…2883) If there are multiple actions running in parallel, they will populate artifacts while another action is still running. This causes a conflict in update of actionset state. Actionset state should be updated by separate function maybeSetActionSetStateComplete Fixes #2882 Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When using actionsets with multiple actions, some actions fail to populate artifacts in the action status.
This is happening because actionset reconciliation expects the entire actionset to be complete when doing that. If there are multiple actions it's not the case.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
All actions in actionsets have their artifacts
Additional context
The call tree is:
Related issues
#2270
#1364
The text was updated successfully, but these errors were encountered: