Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ActionSet artifacts fail to populate in multi-action actionsets #2882

Closed
hairyhum opened this issue May 10, 2024 · 1 comment · Fixed by #2883
Closed

[BUG] ActionSet artifacts fail to populate in multi-action actionsets #2882

hairyhum opened this issue May 10, 2024 · 1 comment · Fixed by #2883

Comments

@hairyhum
Copy link
Contributor

hairyhum commented May 10, 2024

Describe the bug
When using actionsets with multiple actions, some actions fail to populate artifacts in the action status.
This is happening because actionset reconciliation expects the entire actionset to be complete when doing that. If there are multiple actions it's not the case.

To Reproduce
Steps to reproduce the behavior:

  1. Create an actionset referencing multiple actions. E.g. example blueprint from timelog and example blueprint from mysql.
  2. Monitor the action status
  3. See that timelog action did not publish the artifacts, but instead has the template in the artifacts field
  4. See error in the logs showing "ActionSet cannot be complete if any actions are not complete"

Expected behavior
All actions in actionsets have their artifacts

Additional context
The call tree is:

pkg/controller/controller.go::renderActionsetArtifacts which is an action-specific 
    pkg/reconcile/reconcile.go::ActionSet which is not action-specific
      pkg/validate/validate.go::actionSetStatus

Related issues
#2270
#1364

Copy link
Contributor

Thanks for opening this issue 👍. The team will review it shortly.

If this is a bug report, make sure to include clear instructions how on to reproduce the problem with minimal reproducible examples, where possible. If this is a security report, please review our security policy as outlined in SECURITY.md.

If you haven't already, please take a moment to review our project's Code of Conduct document.

@infraq infraq added this to To Be Triaged in Kanister May 10, 2024
hairyhum added a commit that referenced this issue May 10, 2024
If there are multiple actions running in parallel, they will populate
artifacts while another action is still running.
This causes a conflict in update of actionset state.

Actionset state should be updated only when all actions complete by onUpdateActionSet

Fixes #2882
hairyhum added a commit that referenced this issue May 13, 2024
If there are multiple actions running in parallel, they will populate
artifacts while another action is still running.
This causes a conflict in update of actionset state.

Actionset state should be updated by separate function maybeSetActionSetStateComplete

Fixes #2882
hairyhum added a commit that referenced this issue May 13, 2024
If there are multiple actions running in parallel, they will populate
artifacts while another action is still running.
This causes a conflict in update of actionset state.

Actionset state should be updated by separate function maybeSetActionSetStateComplete

Fixes #2882
hairyhum added a commit that referenced this issue May 13, 2024
If there are multiple actions running in parallel, they will populate
artifacts while another action is still running.
This causes a conflict in update of actionset state.

Actionset state should be updated by separate function maybeSetActionSetStateComplete

Fixes #2882
@mergify mergify bot closed this as completed in #2883 May 22, 2024
mergify bot added a commit that referenced this issue May 22, 2024
…2883)

If there are multiple actions running in parallel, they will populate
artifacts while another action is still running.
This causes a conflict in update of actionset state.

Actionset state should be updated by separate function maybeSetActionSetStateComplete

Fixes #2882

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Kanister automation moved this from To Be Triaged to Done May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

1 participant