Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update output artifacts in v2 blueprints #1004

Merged
merged 2 commits into from
May 20, 2021
Merged

Update output artifacts in v2 blueprints #1004

merged 2 commits into from
May 20, 2021

Conversation

pavannd1
Copy link
Contributor

@pavannd1 pavannd1 commented May 20, 2021

Change Overview

  • Add kopiaSnapshot field in output artifacts
  • Some comments in the blueprints to describe the artifacts and output

Based on the changes added in #1001 and #1002

Pull request type

Please check the type of change your PR introduces:

  • 🌻 Feature

Issues

  • #XXX

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Comment on lines -23 to +24
image: ghcr.io/kanisterio/couchbase-tools:0.53.0
image: ghcr.io/kanisterio/couchbase-tools:0.57.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if release script is not updating the image tag

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since it replaces the last version with the next one, if there's ever an error, we'll miss future updates.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we merged this after the release so the script missed these files.

@mergify mergify bot merged commit 6c11103 into master May 20, 2021
@mergify mergify bot deleted the up_v2_bp branch May 20, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants