Remove type field from stable blueprints
#1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are upgrading the CRDs to `v1` from `v1beta1`, and we don't actually specify `type` field in our `types.go` we wont have `types` field in the CR schema. And because of that if we create a blueprint with `types` in it, the validation would failed. I see there would be a problem when these applications are being called from k10, because it looks like k10 needs type for `delete` action. I still am looking into if we really need that or we can change that.
|
@viveksinghggits we would still need |
yes, we would need that. Did I remove that somewhere. |
chaitanya-baraskar
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Since we are upgrading the CRDs to
v1fromv1beta1, and wedon't actually specify
typefield in ourtypes.gowe wonthave
typesfield in the CR schema. And because of that ifwe create a blueprint with
typesin it, the validation wouldfailed.
I see there would be a problem when these applications are being
called from k10, because it looks like k10 needs type for
deleteaction.
I still am looking into if we really need that or we can change that.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Changed blueprint to remove
typefield from it and ran mysql integration test.the logs can be found here
I have tested the change with k10 as well, I created a blueprint without
typefield and then did backup and restore of application. And have tested e2e as well. The logs of e2e can be found here.https://gist.github.com/fdd0fe3032f2736e8e88376150389c48