Fix kafka E2E test uninstall function #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrasadG193
reviewed
Jun 14, 2021
pkg/app/kafka.go
Outdated
Comment on lines
187
to
188
| deleteConfig := []string{"delete", "-n", kc.namespace, "configmap", configMapName} | ||
| out, err := helm.RunCmdWithTimeout(ctx, "kubectl", deleteConfig) |
There was a problem hiding this comment.
Can we use client-go methods instead of calling binary?
PrasadG193
reviewed
Jun 14, 2021
pkg/app/kafka.go
Outdated
| @@ -184,6 +184,11 @@ func (kc *KafkaCluster) Uninstall(ctx context.Context) error { | |||
| return errors.Wrap(err, "failed to create helm client") | |||
| } | |||
|
|
|||
| err = kc.cli.CoreV1().ConfigMaps(kc.namespace).Delete(ctx, configMapName, metav1.DeleteOptions{}) | |||
| if err != nil { | |||
There was a problem hiding this comment.
Suggested change
| if err != nil { | |
| if err != nil && !apierrors.IsNotFound(err) { |
Please add an exception for IsNotFound https://pkg.go.dev/k8s.io/apimachinery/pkg/api/errors#IsNotFound
PrasadG193
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Add functionality to delete an annotated object {i.e Configmap } of Kafka application in uninstall function.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
./build/integration-test.sh KafkaTest log: https://gist.github.com/A-kanksh-a/c635b96f90dc67a479c8ce2d0026a6c7