-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dir support to kando with kopia location #1028
Conversation
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
I think test case 2 and 4 should work if the target path is same as the backup file path. Please try it out. |
@pavannd1 it works on master where we create Reader/Writer from file and pass it to stream handling. But since we have added separate handling for files and streaming data, they are no longer compatible. |
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
// TODO: Do we want to keep this flags configurable? | ||
output := &restore.FilesystemOutput{ | ||
TargetPath: p, | ||
OverwriteDirectories: true, | ||
OverwriteFiles: true, | ||
OverwriteSymlinks: true, | ||
IgnorePermissionErrors: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pavannd1 do we want to have these flags configurable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be okay for now. We can improve later if the requirement comes up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Prasad Ghangal prasad.ghangal@gmail.com
Change Overview
This approach has the following limitations:
Please see the test plan for the details.
Pull request type
Please check the type of change your PR introduces:
Test Plan
Test cases:
--path
arg with same value as source filepath - PASS