Propagate context to child function #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akankshakumari393
changed the title
akankshakumari393
requested review from
PrasadG193,
viveksinghggits and
pavannd1
pkg/controller/controller_test.go
Outdated
| @@ -437,7 +437,7 @@ func (s *ControllerSuite) TestExecActionSet(c *C) { | |||
|
|
|||
| func (s *ControllerSuite) TestRuntimeObjEventLogs(c *C) { | |||
| c.Skip("This may not work in MiniKube") | |||
| ctx := context.TODO() | |||
| contxt := context.TODO() | |||
There was a problem hiding this comment.
Suggested change
| contxt := context.TODO() | |
| ctx := context.TODO() |
There was a problem hiding this comment.
@viveksinghggits I don't think we should do that, ctx is being initialized later in the function with context.Background in line no 468.
There was a problem hiding this comment.
so why don't we use this one there as well.
pavannd1
reviewed
Jul 27, 2021
pkg/controller/controller.go
Outdated
| @@ -122,13 +122,14 @@ func (c *Controller) StartWatch(ctx context.Context, namespace string) error { | |||
| } | |||
|
|
|||
| func checkCRAccess(cli versioned.Interface, ns string) error { | |||
There was a problem hiding this comment.
Refactor to pass in context from StartWatch
pkg/controller/controller.go
Outdated
| @@ -190,15 +191,16 @@ func (c *Controller) onDelete(obj interface{}) { | |||
| } | |||
|
|
|||
| func (c *Controller) onAddActionSet(as *crv1alpha1.ActionSet) error { | |||
| as, err := c.crClient.CrV1alpha1().ActionSets(as.GetNamespace()).Get(context.TODO(), as.GetName(), v1.GetOptions{}) | |||
| ctx := context.TODO() | |||
There was a problem hiding this comment.
This change is not adding much value. No need to change this function until we handle the ActionSet context stuff you are working on in parallel.
pkg/testing/integration_test.go
Outdated
| @@ -304,15 +304,16 @@ func newActionSet(bpName, profile, profileNs string, object crv1alpha1.ObjectRef | |||
| } | |||
|
|
|||
| func (s *IntegrationSuite) createProfile(c *C) string { | |||
| secret, err := s.cli.CoreV1().Secrets(kontroller.namespace).Create(context.TODO(), s.profile.secret, metav1.CreateOptions{}) | |||
| ctx := context.TODO() | |||
pkg/testutil/testutil_test.go
Outdated
| @@ -84,17 +84,18 @@ func (s *TestUtilSuite) TestDeployment(c *C) { | |||
| } | |||
|
|
|||
| cm := NewTestConfigMap() | |||
| cm, err = cli.CoreV1().ConfigMaps(ns.GetName()).Create(context.TODO(), cm, metav1.CreateOptions{}) | |||
| cm, err = cli.CoreV1().ConfigMaps(ns.GetName()).Create(ctx, cm, metav1.CreateOptions{}) | |||
| c.Assert(err, IsNil) | |||
| err = cli.CoreV1().ConfigMaps(ns.GetName()).Delete(context.TODO(), cm.GetName(), metav1.DeleteOptions{}) | |||
| c.Assert(err, IsNil) | |||
| } | |||
|
|
|||
| func testCRs(c *C, cli crclientv1alpha1.CrV1alpha1Interface, namespace, poKind, poName string) { | |||
There was a problem hiding this comment.
Pass it in from above
Suggested change
| func testCRs(c *C, cli crclientv1alpha1.CrV1alpha1Interface, namespace, poKind, poName string) { | |
| func testCRs(c *C, ctx context.Context, cli crclientv1alpha1.CrV1alpha1Interface, namespace, poKind, poName string) { |
pkg/testutil/testutil_test.go
Outdated
| c.Assert(err, IsNil) | ||
| err = cli.CoreV1().ConfigMaps(ns.GetName()).Delete(context.TODO(), cm.GetName(), metav1.DeleteOptions{}) | ||
| c.Assert(err, IsNil) | ||
| } | ||
|
|
||
| func testCRs(c *C, cli crclientv1alpha1.CrV1alpha1Interface, namespace, poKind, poName string) { | ||
| var err error | ||
| ctx := context.TODO() |
There was a problem hiding this comment.
Suggested change
| ctx := context.TODO() |
Co-authored-by: Pavan Navarathna <pavan@kasten.io>
Co-authored-by: Pavan Navarathna <pavan@kasten.io>
Co-authored-by: Pavan Navarathna <pavan@kasten.io>
akankshakumari393
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR is to refactor code and pass the same context object if it’s available in parent call while performing
Create,List,Getoperation.Referred PR #726
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan