vSphere snapshot delete error checking #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlbraganza
reviewed
Jul 8, 2021
pkg/blockstorage/vmware/vmware.go
Outdated
| if soap.IsVimFault(lerr) { | ||
| switch soap.ToVimFault(err).(type) { | ||
| case *types.InvalidArgument: | ||
| log.Debug().WithError(err).Print("Disk doesn't have given snapshot due to the snapshot stamp was removed in the previous DeleteSnapshot operation which failed with InvalidState fault. And it will be resolved by the next snapshot operation on the same VM. Will NOT retry") |
There was a problem hiding this comment.
Grammar!
- "... due to the snapshot stamp being removed..." or "... because the snapshot stamp was removed ..."
- "with an InvalidState fault"
- Sentence starts with "And"
Debug errors are useless as K10 eats them up. Please change to Error.
There was a problem hiding this comment.
So these error messages are copied verbatim. I can change them for our purposes. Will change to error.
carlbraganza
requested changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
The following changes address the issue where a snapshot can be deleted even if the initial result of the delete seems to be unsuccessful. The error handling was that was used belongs to the open source package https://github.com/vmware-tanzu/astrolabe/blob/91eeed4dcf77edd1387a25e984174f159d66fedb/pkg/ivd/ivd_protected_entity.go#L433
Pull request type
Please check the type of change your PR introduces: