Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vsphere timeout error message #1062

Merged
merged 4 commits into from
Jul 30, 2021
Merged

Update vsphere timeout error message #1062

merged 4 commits into from
Jul 30, 2021

Conversation

bathina2
Copy link
Contributor

Change Overview

In case of time out, error may be nil. This will return an error with more info on the volume

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

pavannd1
pavannd1 approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bathina2 bathina2 added the kueue label Jul 30, 2021
@mergify mergify bot merged commit 0b25a49 into master Jul 30, 2021
@mergify mergify bot deleted the vsphere_timeout_error branch July 30, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 approved these changes

@carlbraganza carlbraganza Awaiting requested review from carlbraganza

@vkamra vkamra Awaiting requested review from vkamra

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bathina2 @pavannd1