Make the AWS session token duration a configurable setting #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update callers of the function to pass default duration. Update GetCredentials, so that it accepts the configured assume role duration instead of the previous hard coded default.
the duration of the session token.
Enable debug logging in AWS SDK
Updated an info log to debug log to print the expiration time..
Add back log with assumeRoleDuration. But made it a debug log instead of info log.
Co-authored-by: Pavan Navarathna <pavan@kasten.io>
…o/kanister into session_token_duration
pavannd1
reviewed
Aug 11, 2021
Added comments for the helper function.
pavannd1
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan