-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Kanister func to create K8s resource #1080
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrasadG193
force-pushed
the
func-create-resource
branch
from
September 1, 2021 09:48
2af5fd4
to
1b939ab
Compare
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
PrasadG193
force-pushed
the
func-create-resource
branch
from
September 1, 2021 10:50
1b939ab
to
df8bcbb
Compare
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
PrasadG193
changed the title
[WIP] New Kanister func to create K8s resource
New Kanister func to create K8s resource
Sep 2, 2021
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
tdmanv
reviewed
Sep 6, 2021
pavannd1
reviewed
Sep 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! Just prefer a different name
10 tasks
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
pavannd1
reviewed
Sep 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Posted a question. Merge when resolved.
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
PrasadG193
force-pushed
the
func-create-resource
branch
from
September 16, 2021 07:14
24cfd1c
to
11011ed
Compare
pavannd1
reviewed
Sep 16, 2021
pavannd1
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prasad Ghangal prasad.ghangal@gmail.com
Change Overview
New Kanister function to perform kubectl operations
Pull request type
Please check the type of change your PR introduces:
Test Plan