Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Kanister func to create K8s resource #1080

Merged
merged 15 commits into from
Sep 17, 2021
Merged

New Kanister func to create K8s resource #1080

merged 15 commits into from
Sep 17, 2021

Conversation

PrasadG193
Copy link
Contributor

@PrasadG193 PrasadG193 commented Aug 31, 2021

Signed-off-by: Prasad Ghangal prasad.ghangal@gmail.com

Change Overview

New Kanister function to perform kubectl operations

Pull request type

Please check the type of change your PR introduces:

  • 🌻 Feature

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@PrasadG193 PrasadG193 changed the title [WIP] New Kanister func to create K8s resource New Kanister func to create K8s resource Sep 2, 2021
@PrasadG193 PrasadG193 marked this pull request as ready for review September 2, 2021 05:28
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
pkg/function/kubectl_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Just prefer a different name

pkg/function/kubectl.go Outdated Show resolved Hide resolved
pkg/function/kubectl_test.go Outdated Show resolved Hide resolved
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posted a question. Merge when resolved.

pkg/function/kubeops.go Outdated Show resolved Hide resolved
pkg/kube/kubectl.go Outdated Show resolved Hide resolved
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
pkg/function/kubeops.go Outdated Show resolved Hide resolved
pkg/function/kubeops.go Outdated Show resolved Hide resolved
pkg/function/kubeops.go Outdated Show resolved Hide resolved
pkg/function/kubeops_test.go Outdated Show resolved Hide resolved
pkg/function/kubeops_test.go Outdated Show resolved Hide resolved
pkg/function/kubeops_test.go Outdated Show resolved Hide resolved
pkg/function/kubeops_test.go Outdated Show resolved Hide resolved
pkg/function/kubeops_test.go Outdated Show resolved Hide resolved
pkg/function/kubeops_test.go Outdated Show resolved Hide resolved
@pavannd1 pavannd1 added the kueue label Sep 16, 2021
@mergify mergify bot merged commit 731ad3b into master Sep 17, 2021
@mergify mergify bot deleted the func-create-resource branch September 17, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants