Adding a configurable env for EFS backup vault name #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkamra
reviewed
Sep 22, 2021
pkg/blockstorage/awsefs/awsefs.go
Outdated
| ) | ||
|
|
||
| var ( | ||
| efsBackupVaultName = getEnvAsStringOrDefault(efsBackupVaultNameEnv, defaultK10BackupVaultName) |
There was a problem hiding this comment.
@bathina2 - can we add this to the config map - see NewEFSProvider instead of environment variables?
There was a problem hiding this comment.
@vkamra This will be set in the config map and referred to as an environment variable. See https://github.com/kastenhq/k10/pull/13188
There was a problem hiding this comment.
Oh you mean as an input to create the Provider.
There was a problem hiding this comment.
Oh you mean as an input to create the Provider.
Yep 👍
vkamra
reviewed
Sep 22, 2021
pkg/aws/aws.go
Outdated
| ConfigEFSVaultName = "efsVaultName" | ||
| // EfsBackupVaultNameEnv describes the environment variable used to set the | ||
| // backup vault name. | ||
| EfsBackupVaultNameEnv = "EFS_BACKUP_VAULT_NAME" |
There was a problem hiding this comment.
Why? That's how it will be referenced through K10?
vkamra
reviewed
Sep 22, 2021
pkg/blockstorage/awsefs/awsefs.go
Outdated
| testMarker = "" | ||
| efsType = "EFS" | ||
| defaultK10BackupVaultName = "k10vault" | ||
| testMarker = "" |
There was a problem hiding this comment.
This should also be there. This is the default value in case it's set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This lets the EFS backup vault name be configurable via an environment variable.
Pull request type
Please check the type of change your PR introduces:
Test Plan