Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configurable pod ready wait timeout #1101

Merged
merged 5 commits into from
Sep 24, 2021
Merged

Add configurable pod ready wait timeout #1101

merged 5 commits into from
Sep 24, 2021

Conversation

pavannd1
Copy link
Contributor

Change Overview

  • Adding a way to configure the pod ready wait timeout. It is currently hard coded to 15 minutes
  • This will help tweak it on platforms where binding PVCs to pods might take longer than 15 minutes

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #XXX

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@pavannd1 pavannd1 added the kueue label Sep 24, 2021
onkarbhat
onkarbhat reviewed Sep 24, 2021
View reviewed changes
pkg/kube/pod.go Outdated Show resolved Hide resolved
pkg/kube/pod.go Outdated Show resolved Hide resolved
@pavannd1 pavannd1 removed the kueue label Sep 24, 2021
pavannd1
pavannd1 commented Sep 24, 2021
View reviewed changes
pkg/kube/pod.go Outdated Show resolved Hide resolved
pkg/kube/pod.go Outdated Show resolved Hide resolved
pkg/kube/pod.go Outdated Show resolved Hide resolved
pkg/kube/pod.go Outdated Show resolved Hide resolved
pkg/kube/pod_test.go Outdated Show resolved Hide resolved
onkarbhat
onkarbhat approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@onkarbhat onkarbhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavannd1 pavannd1 added kueue and removed kueue labels Sep 24, 2021
pavannd1
pavannd1 commented Sep 24, 2021
View reviewed changes
pkg/kube/pod.go Outdated Show resolved Hide resolved
pkg/kube/pod.go Outdated Show resolved Hide resolved
pkg/kube/pod.go Outdated Show resolved Hide resolved
pkg/kube/pod.go Outdated Show resolved Hide resolved
pkg/kube/pod_test.go Outdated Show resolved Hide resolved
@pavannd1 pavannd1 added the kueue label Sep 24, 2021
@mergify mergify bot merged commit 6a30be6 into master Sep 24, 2021
@mergify mergify bot deleted the pod_wait_time branch September 24, 2021 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onkarbhat onkarbhat onkarbhat approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

@viveksinghggits viveksinghggits Awaiting requested review from viveksinghggits

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pavannd1 @onkarbhat