Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support delete operation in kubeops function #1102

Merged
merged 3 commits into from
Sep 29, 2021
Merged

Support delete operation in kubeops function #1102

merged 3 commits into from
Sep 29, 2021

Conversation

PrasadG193
Copy link
Contributor

@PrasadG193 PrasadG193 commented Sep 24, 2021

Signed-off-by: Prasad Ghangal prasad.ghangal@gmail.com

Change Overview

Add support for delete operation in kubeops function. The resource details can be provided as objectReference

    - func: KubeOps
      name: deleteDeploy
      args:
        operation: delete
        objectReference:
          apiVersion: "{{ .Phases.createDeploy.Output.apiVersion }}"
          group: "{{ .Phases.createDeploy.Output.group }}"
          resource: "{{ .Phases.createDeploy.Output.resource }}"
          name: "{{ .Phases.createDeploy.Output.name }}"
          namespace: "{{ .Phases.createDeploy.Output.namespace }}"

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Test Plan

$ go test -check.f="KubeOpsSuite" .
OK: 2 passed
PASS
ok github.com/kanisterio/kanister/pkg/function 31.797s

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@mergify mergify bot merged commit aaa9048 into master Sep 29, 2021
@PrasadG193 PrasadG193 removed the kueue label Sep 29, 2021
@mergify mergify bot deleted the kubeops-delete branch September 29, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants