Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set log level using env variable #1105

Merged
merged 3 commits into from
Oct 4, 2021
Merged

Conversation

kale-amruta
Copy link
Contributor

Signed-off-by: Amruta Kale amrutakale24.1991@gmail.com

Change Overview

Kanister by default logs at info level. This PR adds a way to change the log level setting

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #XXX

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Signed-off-by: Amruta Kale <amrutakale24.1991@gmail.com>
@kale-amruta
Copy link
Contributor Author

@PrasadG193 can you review it?

pkg/log/log.go Outdated Show resolved Hide resolved
pkg/log/log.go Outdated Show resolved Hide resolved
pkg/log/log_test.go Outdated Show resolved Hide resolved
Signed-off-by: Amruta Kale <amrutakale24.1991@gmail.com>
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@pavannd1 pavannd1 added the kueue label Oct 4, 2021
@mergify mergify bot merged commit a4f8a4b into kanisterio:master Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants