Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update mongo db blueprint #1106

Merged
merged 6 commits into from
Oct 14, 2021
Merged

update mongo db blueprint #1106

merged 6 commits into from
Oct 14, 2021

Conversation

kale-amruta
Copy link
Contributor

@kale-amruta kale-amruta commented Sep 29, 2021 •
edited

Change Overview

If the mongodb chart is installed with chart name as release name, existing blueprint breaks, This PR updates blueprint to make it work in all usecases

Pull request type

Please check the type of change your PR introduces:

  • 🗺️ Documentation

Issues

  • #XXX

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@kale-amruta
Copy link
Contributor Author

@viveksinghggits can you review it?

@kale-amruta kale-amruta force-pushed the updateReadmeForMongoDB branch 4 times, most recently from 1cc98df to 3452c4e Compare October 5, 2021 05:42
@kale-amruta kale-amruta changed the title examples/stable/mongodb: update README for mongo db example update README for mongo db example Oct 5, 2021
@kale-amruta kale-amruta changed the title update README for mongo db example update mongo db blueprint Oct 5, 2021
@kale-amruta
Copy link
Contributor Author

@PrasadG193 getting from statefulset.Name worked

viveksinghggits
viveksinghggits reviewed Oct 8, 2021
View reviewed changes
Copy link
Contributor

@viveksinghggits viveksinghggits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

examples/stable/mongodb/mongo-blueprint.yaml Outdated Show resolved Hide resolved
@mergify mergify bot merged commit 10f50cf into kanisterio:master Oct 14, 2021
@kale-amruta kale-amruta deleted the updateReadmeForMongoDB branch October 14, 2021 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 left review comments

@viveksinghggits viveksinghggits viveksinghggits approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kale-amruta @pavannd1 @PrasadG193 @viveksinghggits