Make RDSPostgres/Aurora DBSnapshot delete operation Idempotent #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akankshakumari393
changed the title
akankshakumari393
changed the title
akankshakumari393
requested review from
viveksinghggits,
PrasadG193 and
pavannd1
| default: | ||
| return nil, errors.Wrap(err, "Failed to delete snapshot") | ||
| } | ||
| } |
There was a problem hiding this comment.
should we do this for aurora clusters as well.
… cluster in case of delete operation
akankshakumari393
changed the title
viveksinghggits
approved these changes
Sep 30, 2021
Co-authored-by: Pavan Navarathna <pavan@kasten.io>
Co-authored-by: Pavan Navarathna <pavan@kasten.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR makes the delete operation for RDS DB snapshot Idempotent. It looks for the
DB snapshot Not Founderror in the case of PostgreSQL orDBClusterSnapshotNotFoundFaultin the case of Aurora DBCluster and prints the message in the log.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
./build/integration-test.sh RDSPostgreSQLSnaphttps://gist.github.com/A-kanksh-a/f56f06825b42c43653b2678bfde324b1