Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DBSnapshot size information to CreateRDSSnapshot function output #1108

Merged
merged 13 commits into from
Oct 7, 2021
Merged

Add DBSnapshot size information to CreateRDSSnapshot function output #1108

merged 13 commits into from
Oct 7, 2021

Conversation

akankshakumari393
Copy link
Contributor

@akankshakumari393 akankshakumari393 commented Oct 1, 2021 •
edited

Change Overview

  • Add RDS DBSnapshot storage size information [allocatedStorage ] to output artifact of CreateRDSSnapshot function.
  • Update Kanister Docs for CreateRDSSnapshot function.
  • Add allocatedStorage information as output artifact of backup Action in RDS Postgres snapshot blueprint.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #XXX

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

./build/integration-test.sh RDSPostgreSQLSnap
Successful output log: https://gist.github.com/A-kanksh-a/689c33ab4ac959fa0e45f5679eaa0b74

@akankshakumari393 akankshakumari393 changed the title Add RDS Snapshot size to Kanister artifact Add DBSnapshot allocated storage information to CreateRDSSnapshot function output Oct 1, 2021
@akankshakumari393 akankshakumari393 changed the title Add DBSnapshot allocated storage information to CreateRDSSnapshot function output Add DBSnapshot size information to CreateRDSSnapshot function output Oct 1, 2021
@akankshakumari393 akankshakumari393 marked this pull request as ready for review October 4, 2021 08:37
pavannd1
pavannd1 approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 54de77f into master Oct 7, 2021
@mergify mergify bot deleted the rds_allocated_storage branch October 7, 2021 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrasadG193 PrasadG193 PrasadG193 left review comments

@pavannd1 pavannd1 pavannd1 approved these changes

@viveksinghggits viveksinghggits Awaiting requested review from viveksinghggits

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akankshakumari393 @pavannd1 @PrasadG193