prefer GetBucketLocation() API for s3-compatible endpoints #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shrekster
force-pushed
the
global-region-for-global-apis
branch
10 times, most recently
from
b51dfc0
to
a2beae5
Compare
Shrekster
force-pushed
the
global-region-for-global-apis
branch
from
a2beae5
to
2004319
Compare
Shrekster
changed the title
Shrekster
requested review from
onkarbhat,
pavannd1,
tdmanv,
DeepikaDixit and
miquella
Co-authored-by: Tom Manville <tom@kasten.io>
tdmanv
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
The
GetBucketRegion()API response from OVH Cloud is inconsistent with and without credentials (anonymous), so we make a change here to preferGetBucketLocation()when possible for s3-compatible stores (explicit endpoint has been specified).Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan