Update restore cmd in postgres depconfig blueprint #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently figure out [an issue](#1116) where the restore command in our blueprint was not working for postgres applications. We fixed that for other application in the mentioned PR this PR fixes the issue for the postgres application that gets deployed as deployment config in OCP clusters.
PrasadG193
approved these changes
Oct 19, 2021
| @@ -61,7 +61,7 @@ actions: | |||
| export PGUSER='postgres' | |||
| export PGPASSWORD='{{ index .Phases.pgRestore.Secrets.pgSecret.Data "postgresql_admin_password" | toString }}' | |||
| BACKUP_LOCATION={{ .ArtifactsIn.cloudObject.KeyValue.backupLocation }} | |||
| kando location pull --profile '{{ toJson .Profile }}' --path "${BACKUP_LOCATION}" - | gunzip -c -f | psql -q -U "${PGUSER}" | |||
| kando location pull --profile '{{ toJson .Profile }}' --path "${BACKUP_LOCATION}" - | gunzip -c -f | sed 's/LOCALE/LC_COLLATE/' | psql -q -U "${PGUSER}" | |||
There was a problem hiding this comment.
Should we tag older blueprint with postgres 12.0 or something like that if someone wants to work with older version of postgres?
There was a problem hiding this comment.
We are still not sure that this change is required, I was suspecting that this would resolve the openshift nightly pipeline failure.
There was a problem hiding this comment.
kueueing this for now.
tdmanv
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
We recently figure out an issue where the restore command in our
blueprint was not working for postgres applications.
We fixed that for other application in the mentioned PR this
PR fixes the issue for the postgres application that gets
deployed as deployment config in OCP clusters.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
logs can be found here.
https://gist.github.com/viveksinghggits/288690790176b1f4cce2d3dd52afca1e