Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make postgres PITR blueprint compatible with postgres 12+ #1127

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Make postgres PITR blueprint compatible with postgres 12+ #1127

merged 1 commit into from
Nov 2, 2021

Conversation

PrasadG193
Copy link
Contributor

@PrasadG193 PrasadG193 commented Nov 1, 2021 •
edited

Signed-off-by: Prasad Ghangal prasad.ghangal@gmail.com

Change Overview

  • Make postgres PITR blueprint compatible with postgres 12+
  • Enable PITRPostgreSQL test app in integration test suite

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E
PITRPostgreSQL integration test passed locally
$ ./build/integration-test.sh ^PITRPostgreSQL$

@PrasadG193
Make postgres PITR blueprint compatible with postgres 12+
0c9d261 
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@PrasadG193
Copy link
Contributor Author

Ref: https://www.cybertec-postgresql.com/en/recovery-conf-is-gone-in-postgresql-v12/

akankshakumari393
akankshakumari393 reviewed Nov 2, 2021
View reviewed changes
Copy link
Contributor

@akankshakumari393 akankshakumari393 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@mergify mergify bot merged commit 961ea96 into master Nov 2, 2021
@mergify mergify bot deleted the enable-pitr-test-app branch November 2, 2021 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akankshakumari393 akankshakumari393 akankshakumari393 approved these changes

@pavannd1 pavannd1 Awaiting requested review from pavannd1

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PrasadG193 @akankshakumari393