Functionality to call ingress operations after discovering APIVersion #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds wrapper around the std API's get and list methods so that we can first figure out which api version ingresses are part of, and then can call the respective methods.
viveksinghggits
force-pushed
the
ingress-discovery
branch
from
2669e37
to
9e70a2a
Compare
viveksinghggits
changed the title
Apart from getting/listting and creating the ingress resources we would also need to get the ingress path of provided ingress resource. Since that would depend on which APIVersion the ingress resource is from, its better we have that method as part of this interface.
denisvmedia
reviewed
Nov 18, 2021
denisvmedia
approved these changes
Nov 18, 2021
pavannd1
reviewed
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
To support k8s version 1.17 and 1.22 we will have to make sure that we are getting the ingress resources from the api version that is present on the cluster, for example we can not get ingresses from api version networking/v1 on k8s versions 1.22.
This PR adds wrappers that can be used to figure out which api version ingresses are part and then call the helper methods to eventually call the verb methods (get/list) from respective apis.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan