Tagging support #1146
Merged
Tagging support #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'master' of https://github.com/kanisterio/kanister into vsphere_snapshot_tagging
carlbraganza
reviewed
Dec 6, 2021
pkg/blockstorage/vmware/vmware.go
Outdated
Comment on lines
115
to
117
| Cns: cnsCli, | ||
| Gom: gom, | ||
| TagManager: tm, |
There was a problem hiding this comment.
Expose the tagging client and hide your interface.
carlbraganza
reviewed
Dec 6, 2021
pkg/blockstorage/vmware/vmware.go
Outdated
| Cns *cns.Client | ||
| Gom *vslm.GlobalObjectManager | ||
| Cns *cns.Client | ||
| TagManager tagManager |
There was a problem hiding this comment.
Expose the tagging service client too - the FcdProvider type is used in CBT which could need it over time.
Hide your internal interface variable - it is really tacky anyway to expose a variable to an internal interface.
carlbraganza
reviewed
Dec 6, 2021
pkg/blockstorage/vmware/vmware.go
Outdated
| // GetOrCreateCategory takes a category name and attempts to get or create the category | ||
| // it returns the category ID. | ||
| func (p *FcdProvider) GetOrCreateCategory(ctx context.Context, categoryName string) (string, error) { | ||
| cat, err := p.TagManager.GetCategory(ctx, categoryName) |
There was a problem hiding this comment.
Why not use p.GetCategoryID here?
carlbraganza
reviewed
Dec 6, 2021
pkg/blockstorage/vmware/vmware.go
Outdated
| value string | ||
| } | ||
|
|
||
| func (t *snapshotTag) print() string { |
There was a problem hiding this comment.
This signature should be String() string.
carlbraganza
reviewed
Dec 6, 2021
pkg/blockstorage/vmware/vmware.go
Outdated
| } | ||
|
|
||
| // setTagsSnapshot sets tags for a snapshot | ||
| func (p *FcdProvider) setTagsSnapshot(ctx context.Context, snapshot *blockstorage.Snapshot, tags map[string]string) error { |
carlbraganza
reviewed
Dec 6, 2021
pkg/blockstorage/vmware/vmware.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func (p *FcdProvider) deleteTagsSnapshot(ctx context.Context, snapshot *blockstorage.Snapshot) error { |
carlbraganza
reviewed
Dec 6, 2021
pkg/blockstorage/vmware/vmware.go
Outdated
| return fmt.Sprintf("%s:%s:%s:%s", volid, snapid, key, value) | ||
| } | ||
|
|
||
| func (p *FcdProvider) parseTag(tag string) (*snapshotTag, error) { |
There was a problem hiding this comment.
This should be
func (t *snapshotTag) Parse(string) error
carlbraganza
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
The following PR introduces the snapshot tagging for vsphere
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan