Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create method in the ingress manager interface #1152

Merged
merged 5 commits into from
Dec 14, 2021
Merged

Conversation

viveksinghggits
Copy link
Contributor

Change Overview

As part of this PR we added the functionality to interact with ingress resources after figuring out the apiVersion they are part of.
This PR adds create method in that interface.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #XXX

Test Plan

NA

Copy link
Contributor

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions for error log statement.

pkg/kube/ingress/ingress_extbeta.go Outdated Show resolved Hide resolved
pkg/kube/ingress/ingress_netbeta.go Outdated Show resolved Hide resolved
@mergify mergify bot merged commit e88bf94 into master Dec 14, 2021
@mergify mergify bot deleted the ingress-mgr-create branch December 14, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants