Fallback to extensions/v1beta1 for ingress APIs in case of fake CLI
#1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viveksinghggits
force-pushed
the
ing-mgr-fix
branch
from
289587f
to
43a0826
Compare
pavannd1
reviewed
Dec 15, 2021
chaitanya-baraskar
approved these changes
Dec 15, 2021
viveksinghggits
changed the title
extensions/v1beta1 for ingress APIs in case of fake CLI
viveksinghggits
changed the title
extensions/v1beta1 for ingress APIs in case of fake CLIextensions/v1beta1 for ingress APIs in case of fake CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
While creating ingress manager to interact with ingress resources based on apiVersion, we were failing when fake kubeclient was passed.
This PR tries to default to
extensions/v1beta1in that case.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan