Add new zones to AWS #1157
Merged
Add new zones to AWS #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TribalNightOwl
approved these changes
Dec 14, 2021
julio-lopez
reviewed
Dec 14, 2021
pkg/blockstorage/awsebs/awsebs.go
Outdated
| @@ -736,6 +736,9 @@ func staticRegionToZones(region string) ([]string, error) { | |||
| "eu-central-1a", | |||
| "eu-central-1b", | |||
| "eu-central-1c", | |||
| "eu-central-1-wl1-ber-wlz-1", | |||
There was a problem hiding this comment.
That's an interesting naming scheme.
Is there an official documentation link for these?
There was a problem hiding this comment.
The names are defined by AWS. We call the list regions API and these are the values it provides.
There was a problem hiding this comment.
This is what the AWS CLI spews out:
aws ec2 describe-availability-zones --region eu-central-1 |jq .AvailabilityZones[].ZoneName
"eu-central-1a"
"eu-central-1b"
"eu-central-1c"
There was a problem hiding this comment.
@julio-lopez The result varies by the credentials I think. Another reason why this should be dynamic.
There was a problem hiding this comment.
x-references:
aws ec2 describe-availability-zones --all-availability-zones --region eu-central-1 |jq .AvailabilityZones[].ZoneName
"eu-central-1a"
"eu-central-1b"
"eu-central-1c"
"eu-central-1-wl1-ber-wlz-1"
"eu-central-1-wl1-dtm-wlz-1"
"eu-central-1-wl1-muc-wlz-1"
julio-lopez
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
The following PR add the new missing zones to AWS.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan