Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to add owner references while creating a pod #1164

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Option to add owner references while creating a pod #1164

merged 2 commits into from
Jan 4, 2022

Conversation

kale-amruta
Copy link
Contributor

@kale-amruta kale-amruta commented Dec 29, 2021 •
edited

Change Overview

There is a requirement to create backup-data-stats pod with owner references. This PR adds an option that can be used to create a pod with owner references

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #XXX

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@kale-amruta kale-amruta marked this pull request as draft December 29, 2021 10:15
@kale-amruta kale-amruta changed the title [WIP] Add owner references to pod options [WIP] Add owner references as pod options Dec 29, 2021
@kale-amruta kale-amruta changed the title [WIP] Add owner references as pod options [WIP] Add owner references while creating a pod Dec 29, 2021
@kale-amruta kale-amruta changed the title [WIP] Add owner references while creating a pod [WIP] Option to add owner references while creating a pod Dec 29, 2021
@kale-amruta kale-amruta marked this pull request as ready for review December 30, 2021 04:30
@kale-amruta kale-amruta changed the title [WIP] Option to add owner references while creating a pod Option to add owner references while creating a pod Dec 30, 2021
@kale-amruta kale-amruta requested review from pavannd1 and removed request for pavannd1 December 30, 2021 06:01
@kale-amruta kale-amruta force-pushed the ownerReferences branch 2 times, most recently from fb44575 to c6ea127 Compare December 30, 2021 12:06
@viveksinghggits
Copy link
Contributor

LGTM

@mergify mergify bot merged commit c7ad60e into kanisterio:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrasadG193 PrasadG193 PrasadG193 approved these changes

@viveksinghggits viveksinghggits Awaiting requested review from viveksinghggits

@pavannd1 pavannd1 Awaiting requested review from pavannd1

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kale-amruta @viveksinghggits @PrasadG193