Added integration test for MSSQL app #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaitanya-baraskar
force-pushed
the
mssql-blueprint
branch
from
7ba7b2e
to
4bca0d7
Compare
chaitanya-baraskar
changed the title
chaitanya-baraskar
force-pushed
the
mssql-blueprint
branch
from
5530242
to
cdea083
Compare
chaitanya-baraskar
changed the title
PrasadG193
reviewed
Jan 12, 2022
chaitanya-baraskar
force-pushed
the
mssql-blueprint
branch
from
2141ffb
to
41dc235
Compare
PrasadG193
reviewed
Jan 12, 2022
PrasadG193
reviewed
Jan 12, 2022
pkg/app/mssql.go
Outdated
| "strings" | ||
| "time" | ||
|
|
||
| "github.com/ghodss/yaml" |
There was a problem hiding this comment.
can we not use standard yaml package. Or the one from api machinery.
There was a problem hiding this comment.
sure let me try that.
pavannd1
reviewed
Jan 14, 2022
PrasadG193
approved these changes
Jan 14, 2022
viveksinghggits
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Added new app MSSQL and Integration test for same.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
To run Intregration test for MSSQL App -
build/integration-test.sh ^MSSQL$