Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using dynamic methods to fetch zones. #1185

Merged
merged 10 commits into from
Jan 22, 2022
Merged

Using dynamic methods to fetch zones. #1185

merged 10 commits into from
Jan 22, 2022

Conversation

bathina2
Copy link
Contributor

Change Overview

The following PR using dynamic methods to fetch zones for GCP, AWS and Azure

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #XXX

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

pkg/blockstorage/awsebs/awsebs.go Outdated Show resolved Hide resolved
pkg/blockstorage/awsebs/awsebs.go Outdated Show resolved Hide resolved
pkg/blockstorage/awsebs/awsebs_test.go Show resolved Hide resolved
pkg/blockstorage/azure/azuredisk.go Outdated Show resolved Hide resolved
pkg/blockstorage/azure/azuredisk.go Outdated Show resolved Hide resolved
pkg/blockstorage/awsebs/awsebs_test.go Outdated Show resolved Hide resolved
pkg/blockstorage/azure/client_test.go Show resolved Hide resolved
pkg/blockstorage/gcepd/client_test.go Show resolved Hide resolved
pkg/blockstorage/gcepd/gcepd.go Outdated Show resolved Hide resolved
Copy link
Contributor

@onkarbhat onkarbhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit: 🚢

@bathina2 bathina2 added the kueue label Jan 22, 2022
@mergify mergify bot merged commit 15ff2bb into master Jan 22, 2022
@mergify mergify bot deleted the K10-9229 branch January 22, 2022 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants