Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding label to SQL Server deployment #1190

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Adding label to SQL Server deployment #1190

merged 1 commit into from
Jan 17, 2022

Conversation

chaitanya-baraskar
Copy link
Contributor

@chaitanya-baraskar chaitanya-baraskar commented Jan 17, 2022 •
edited

Change Overview

Added label app: mssql to SQL Server deployment

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #XXX

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Run following command to execute integration test -

build/integration-test.sh ^MSSQL$

OK: 1 passed
--- PASS: Test (121.11s)
PASS
ok  	github.com/kanisterio/kanister/pkg/testing	121.163s
~/Projects/kasten/kanister

@viveksinghggits
Copy link
Contributor

why do we need this?

@chaitanya-baraskar
Copy link
Contributor Author

@viveksinghggits Kopia blueprint looks for app: mssql label to resolve template. That's why added this label.

@mergify mergify bot merged commit 509dd5f into master Jan 17, 2022
@mergify mergify bot deleted the mssql-test-fix branch January 17, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveksinghggits viveksinghggits viveksinghggits approved these changes

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chaitanya-baraskar @viveksinghggits