Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor integration tests #1191

Merged
merged 3 commits into from
Jan 20, 2022
Merged

Refactor integration tests #1191

merged 3 commits into from
Jan 20, 2022

Conversation

viveksinghggits
Copy link
Contributor

@viveksinghggits viveksinghggits commented Jan 17, 2022

Change Overview

  • Use OCP release version 4.9 for deployment config apps
  • Remove MongoDB from OCP apps because this app is not dropped from
    external templates
  • Call Reset before calling Initialize for the application from integration_test.go

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #XXX

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Run

make openshift-test

and

make integration-test

to test the applications on openshift and normal k8s clusters respectively.

https://gist.github.com/viveksinghggits/227d8a54b31621f87605b71a82ec1488

- Use OCP release version 4.9 for deployment config apps
- Remove MongoDB from OCP apps because this app is not dropped from
external templates
- Call `Reset` before calling `Initialize` for the application
@mergify mergify bot merged commit bfe366c into master Jan 20, 2022
@mergify mergify bot deleted the rm-mongodepconf-49 branch January 20, 2022 08:30
@eric-nadeau eric-nadeau mentioned this pull request Jun 13, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants