Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update KubeOps to support core group & wait for delete completion #1199

Merged
merged 19 commits into from
Jan 28, 2022
Merged

Update KubeOps to support core group & wait for delete completion #1199

merged 19 commits into from
Jan 28, 2022

Conversation

shlokc9
Copy link
Contributor

@shlokc9 shlokc9 commented Jan 20, 2022 •
edited

Change Overview

This PR consists of updates to KubeOps function to support create & delete for core group resources

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@shlokc9 shlokc9 changed the title Update KubeOps function Update KubeOps to support create & delete for core group Jan 20, 2022
@shlokc9 shlokc9 changed the title Update KubeOps to support create & delete for core group Update KubeOps to support core resources & wait for delete completion Jan 21, 2022
@shlokc9 shlokc9 changed the title Update KubeOps to support core resources & wait for delete completion Update KubeOps to support core group & wait for delete completion Jan 21, 2022
PrasadG193
PrasadG193 reviewed Jan 21, 2022
View reviewed changes
pkg/function/kubeops_test.go Outdated Show resolved Hide resolved
pkg/kube/kubectl.go Outdated Show resolved Hide resolved
@shlokc9
Copy link
Contributor Author

shlokc9 commented Jan 21, 2022

@PrasadG193 Please have a look

PrasadG193
PrasadG193 reviewed Jan 21, 2022
View reviewed changes
pkg/kube/kubectl.go Outdated Show resolved Hide resolved
pkg/kube/kubectl.go Show resolved Hide resolved
PrasadG193
PrasadG193 reviewed Jan 24, 2022
View reviewed changes
pkg/kube/kubectl.go Outdated Show resolved Hide resolved
pkg/kube/kubectl.go Show resolved Hide resolved
@shlokc9 shlokc9 linked an issue Jan 24, 2022 that may be closed by this pull request
[BUG] KubeOps core group not supported & delete operation does not wait on resource deletion #1204
Closed
@shlokc9 shlokc9 mentioned this pull request Jan 24, 2022
Closed
@shlokc9 shlokc9 requested a review from pavannd1 January 25, 2022 06:50
pavannd1
pavannd1 reviewed Jan 26, 2022
View reviewed changes
pkg/function/kubeops_test.go Outdated Show resolved Hide resolved
pkg/kube/kubectl.go Show resolved Hide resolved
pkg/kube/kubectl.go Outdated Show resolved Hide resolved
pavannd1
pavannd1 reviewed Jan 28, 2022
View reviewed changes
pkg/kube/kubectl.go Outdated Show resolved Hide resolved
pavannd1
pavannd1 approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shlokc9 shlokc9 added the kueue label Jan 28, 2022
@mergify mergify bot merged commit 5068148 into master Jan 28, 2022
@mergify mergify bot deleted the kubeops-update branch January 28, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 approved these changes

@viveksinghggits viveksinghggits Awaiting requested review from viveksinghggits

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] KubeOps core group not supported & delete operation does not wait on resource deletion
3 participants
@shlokc9 @pavannd1 @PrasadG193