Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new integration test for CSI Snapshot Blueprint #1208

Merged
merged 236 commits into from
Feb 4, 2022
Merged

Add new integration test for CSI Snapshot Blueprint #1208

merged 236 commits into from
Feb 4, 2022

Conversation

shlokc9
Copy link
Contributor

@shlokc9 shlokc9 commented Jan 24, 2022 •
edited

Change Overview

This PR consists of an integration test for the CSI Snapshot example Blueprint

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@shlokc9
Added new function CreateCSISnapshot
d4fb11b
@shlokc9
Fixed the instantiated values for kubeCli and dynCli
a611202
@shlokc9
Added waitForReady=true as the default
12bb95e
@shlokc9
Added apiGroup snapshot.storage.k8s.io in cluster-role for kanister-o…
c61c169 
…perator
@shlokc9
Added documentation for Create CSI VolumeSnapshot Func
ebf0dd7
@shlokc9
Changed namespace to a required arg
cfc04eb
@shlokc9
Rasults of running gofmt
4b6dd11
@shlokc9
Reverting changes to return type of snapshotter.Create()
719db52
@shlokc9
Added new function RestoreCSISnapshot
f6aa6a8
@shlokc9
Changed snapShotter -> snapshotter
f41d49a
@shlokc9
grouped imports and added the comment for 'waitForReady'
1c6cd0c
@shlokc9
Updates suggested in docs/functions.rst
6570c1d
@shlokc9
Changed snapshot name argument to optional argument and added a defau…
3320c41 
…lt value
@shlokc9
reviewer comments
376e7a3
@shlokc9
Changes suggested in reviewer comments
4dad68d
@shlokc9
gofmt update
64ba80d
@shlokc9
Merge branch 'func-create-csi-snapshot' of https://github.com/kaniste…
49c7919 
…rio/kanister into test-kan-csi-snapshot-funcs
@shlokc9
gofmt update
88d2221
@shlokc9
Merge branch 'func-create-csi-snapshot' of https://github.com/kaniste…
36c1264 
…rio/kanister into func-create-csi-snapshot
@shlokc9
Fixed failed to render outputartifact template 'snapshotInfo' issue
d4731e5
@shlokc9
Merge branch 'func-create-csi-snapshot' of https://github.com/kaniste…
ec69009 
…rio/kanister into test-kan-csi-snapshot-funcs
@shlokc9
Merge branch 'func-restore-csi-snapshot' of https://github.com/kanist…
5404f42 
…erio/kanister into test-kan-csi-snapshot-funcs
@shlokc9
Updated const comments and function description in documentation
ca5c0bf
@shlokc9
Updated const comments
5d7d94a
@shlokc9
Updated the return obj for the function
dba3c4d
@shlokc9
Declared and used const for outputartifact keys
63b62ef
@shlokc9
Added documentation for RestoreCSISnapshot function
9d59a1b
@shlokc9
Merged origin/fun-restore-csi-snapshot into this branch
f18e0ac
@shlokc9
Merge branch 'func-create-csi-snapshot' of https://github.com/kaniste…
0a8cfe9 
…rio/kanister into test-kan-csi-snapshot-funcs
@shlokc9
Minor changes in docs/functions.rst
27343b4
@shlokc9 shlokc9 changed the title Integration test for CSI Snapshot Blueprint Add new integration test for CSI Snapshot Blueprint Jan 27, 2022
@shlokc9 shlokc9 force-pushed the csi-snapshot-funcs-integration-test branch from 012e72c to c3dc9a0 Compare January 28, 2022 09:26
@shlokc9
Copy link
Contributor Author

shlokc9 commented Jan 31, 2022

@PrasadG193 @viveksinghggits @pavannd1 This PR ready to be reviewed

Install CSI hostpath driver in kind cluster that we setup in CI (#1212)
3557701 
* Install CSI driver

* Update in install_csi_hostpath_driver method

* Remove default storageclass patch

* Update the default storageclass

* Run CSI driver install before minio setup in Travis CI

* Remove patch steps from CSISnapshot integration test
pavannd1
pavannd1 reviewed Jan 31, 2022
View reviewed changes
pkg/app/csi-snapshot.go Outdated Show resolved Hide resolved
pkg/app/csi-snapshot.go Outdated Show resolved Hide resolved
pkg/app/csi-snapshot.go Outdated Show resolved Hide resolved
pkg/app/csi-snapshot.go Outdated Show resolved Hide resolved
pavannd1
pavannd1 approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shlokc9 shlokc9 added the kueue label Feb 3, 2022
@mergify mergify bot merged commit 307b053 into master Feb 4, 2022
@mergify mergify bot deleted the csi-snapshot-funcs-integration-test branch February 4, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

@viveksinghggits viveksinghggits Awaiting requested review from viveksinghggits

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shlokc9 @viveksinghggits @pavannd1