Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for snapshot to be deleted in DeleteCSISnapshot function #1210

Merged
merged 3 commits into from
Jan 29, 2022
Merged

Wait for snapshot to be deleted in DeleteCSISnapshot function #1210

merged 3 commits into from
Jan 29, 2022

Conversation

shlokc9
Copy link
Contributor

@shlokc9 shlokc9 commented Jan 27, 2022 •
edited

Change Overview

Waits for VolumeSnapshot to be deleted before completing the execution of DeleteCSISnapshot function

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@viveksinghggits
Copy link
Contributor

LGTM

@shlokc9 shlokc9 added the kueue label Jan 29, 2022
@mergify mergify bot merged commit abfbcbd into master Jan 29, 2022
@mergify mergify bot deleted the wait-for-delete-csi-snapshot branch January 29, 2022 10:10
@muffl0n
Copy link
Contributor

muffl0n commented Feb 1, 2022

Awesome! Thank you! 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

@viveksinghggits viveksinghggits Awaiting requested review from viveksinghggits

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shlokc9 @viveksinghggits @muffl0n @pavannd1