Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example for KubeOps #1215

Merged
merged 2 commits into from
Feb 2, 2022
Merged

Fix example for KubeOps #1215

merged 2 commits into from
Feb 2, 2022

Conversation

muffl0n
Copy link
Contributor

@muffl0n muffl0n commented Feb 1, 2022

Change Overview

spec needs to be a string, so we prepend |-

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

n/a

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@muffl0n
Fix example for KubeOps
de8f4d5 
`spec` needs to be a string
shlokc9
shlokc9 approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@shlokc9 shlokc9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. |- was missing in the example of KubeOps function. spec argument is of type string. Thanks for pointing this out @muffl0n :)

@mergify mergify bot merged commit 9e1fa1b into kanisterio:master Feb 2, 2022
@muffl0n muffl0n deleted the fix-doc-kubeops branch February 2, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveksinghggits viveksinghggits viveksinghggits approved these changes

@shlokc9 shlokc9 shlokc9 approved these changes

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muffl0n @viveksinghggits @shlokc9