Use CONTAINER_NAME if set #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support cgroups v2 systems such as Docker Desktop for Mac 4.3+.
pavannd1
approved these changes
Feb 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Use CONTAINER_NAME if set instead of attempting to parse /proc/self/cgroup.
Supports cgroups v2 systems such as Docker Desktop for Mac 4.3+.
Approach of CONTAINER_NAME has been used successfully for K10. To maintain independence of Kanister from K10 in workflows that do not set CONTAINER_NAME, this change detects being in a container if either CONTAINER_NAME set or if detected from /proc/self/cgroup.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan