Distribute CRDs using helm chart #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CRDs for now were being deployed using controller, we should make sure CRDs are being distributed by helm chart preferrably but if we are consuming kanister not as sub chart in that case they can set an env var in the kanister pod to make sure CRDs are being created.
ihcsim
reviewed
Feb 13, 2022
There was a problem hiding this comment.
Thanks for working on this. I am sort of hesitant to let Helm manage CRDs because by default, Helm can't upgrade nor delete CRDs in future chart versions. We are not gaining much other than the "one chart" installation experience, and now users become responsible for upgrading the CRDs.
I wonder if we should default createCRDs to true to continue let the controller manage the CRDs, with false being the 'break glass' approach. (Also see also comment below on upgrading existing Helm releases.) WDYT?
pavannd1
requested review from
miquella
and removed request for
vkamra and
PrasadG193
miquella
reviewed
Feb 17, 2022
- rename helm field `createCRDs` to `updateCRDs` - refactor order of embedded files
pavannd1
reviewed
Feb 22, 2022
ihcsim
reviewed
Feb 22, 2022
When we didn't have this `updateCRDs` flag in values.yaml controller was responsible to create/update the CRDs. To make sure that we follow the same default path we are changing the default value of `updateCRDs` to `true`, so that kanister controller will be responsible to manager crds. If thats not required/possible, this flag can be set to false.
ihcsim
reviewed
Feb 28, 2022
ihcsim
approved these changes
Mar 2, 2022
|
I will let @pavannd1 have a look and then |
pavannd1
approved these changes
Mar 8, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
CRDs for now were being deployed using controller, we
should make sure CRDs are being distributed by helm
chart preferrably but if we are consuming kanister not
as sub chart in that case they can set an env var
in the kanister pod to make sure CRDs are being created.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Helm install manifests
the manifest can be found here.
with
createCRDs: truethe generated manifest can be found here