Make sure kanctl honors KUBECONFIG env and kubeconfig dir
#1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanctl in current implentation create kubeclient using `inClusterConfig` it doesn't check if the `KUBECONFIG` env var is set or config file is available at default location. This has resulted into problem for some of the users. This PR makes the change to prioritise creating kubeclient in below order - KUBECONFIG env var - kubeconfig file at deafult location `~/.kube/config` - Use `inClusterConfig`
pavannd1
reviewed
Feb 17, 2022
pavannd1
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
kanctl in current implentation create kubeclient using
inClusterConfigit doesn't check if the
KUBECONFIGenv var is set or config file isavailable at default location.
This has resulted into problem for some of the users. This PR makes the
change to prioritise creating kubeclient in below order
~/.kube/configinClusterConfigPull request type
Please check the type of change your PR introduces:
Issues
Test Plan